fix: handle trl compatibility for DataCollatorForCompletionOnlyLM#169
Closed
YashasviChaurasia wants to merge 1 commit intofoundation-model-stack:mainfrom
Closed
Conversation
…lyLM Handle different trl versions gracefully to fix ImportError when using trl >= 0.19. Problem: - In trl < 0.19: DataCollatorForCompletionOnlyLM is exported from trl - In some trl >= 0.19 versions: May be moved or renamed - Current code fails with: ImportError: cannot import name 'DataCollatorForCompletionOnlyLM' from 'trl' Solution: - Try importing from trl first (works for most versions) - Fallback to trl.trainer.utils if not found - Create placeholder class if neither works (allows plugin to load) This unblocks training when using transformers v5 (which requires trl >= 0.19). Fixes compatibility with: - transformers v5.x + trl v0.19+ - Maintains backward compatibility with older trl versions Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle different trl versions gracefully to fix ImportError when using trl >= 0.19.
Problem:
Solution:
This unblocks training when using transformers v5 (which requires trl >= 0.19).
Fixes compatibility with: